fix(eval): reject authored execution concurrency - #1634
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
453291e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bbd40a63.agentv.pages.dev |
| Branch Preview URL: | https://promptfoo-concurrency-align.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Authored eval YAML now rejects
execution.max_concurrencyand directs authors toevaluate_options.max_concurrency, matching the PromptfooevaluateOptions.maxConcurrencyconvention while preserving.agentv/config.yamlexecution.max_concurrencyas operator run policy.This also updates validator/parser tests, regenerated eval schema data, public v4.42.4 eval docs, and migration guidance so removed
workerspaths no longer send users back to the removed authoredexecution.max_concurrencysurface.Validation
bun test packages/core/test/evaluation/loaders/config-loader.test.ts packages/core/test/evaluation/validation/eval-file-schema.test.ts packages/core/test/evaluation/validation/eval-validator.test.ts packages/core/test/evaluation/validation/eval-schema-sync.test.tsbun test packages/core/test/evaluation/eval-inline-experiment.test.ts packages/core/test/evaluation/config.test.tsbun run validate:examplesbun run buildbun run lintexecution.max_concurrencyeval fails with guidance toevaluate_options.max_concurrencyevaluate_options.max_concurrencyeval validates successfullyLive provider/grader dogfood was not run because this changes eval authoring validation/schema/docs only; it does not change provider execution, grader behavior, run artifacts, or result provenance.
Review Notes
/home/entity/projects/promptfoo/promptfooat6bfc5a0c7f16f9c4717ac731d276b578e63d0769.Post-Deploy Monitoring & Validation
No additional production monitoring required. This is a local validation/schema/docs change with no service runtime path.
Expected healthy signals:
evaluate_options.max_concurrencycontinue to validate and run.execution.max_concurrencyin eval YAML receive the new actionable validation error.Failure signals and rollback trigger:
evaluate_options.max_concurrencyare rejected..agentv/config.yamlexecution.max_concurrencystops working as project/operator policy.Validation window and owner: PR review and GitHub Actions before merge; coordinator owns Bead closure after merge.
Related
Related: av-kfik.23